Skip to content

test_pyo3_wrapper: _link_libpython_wrapper skips on any build failure, not only a missing libpython #336

Description

@terasakisatoshi

Found by Codex on PR #334 (docs). _link_libpython_wrapper in test/test_pyo3_wrapper.jl (lines ~42–54) wraps link planning, the crate scan and build_pyo3_wrapper in one try … catch and turns any exception into @info "skipping the :link_libpython wrapper testset". The intent is to skip on machines without a linkable libpython3.x; the effect is that a wrapper code-generation, Cargo or compiler regression also reports as a skip — on Ubuntu CI too, where a linkable Python exists — so the suite can go green without having built a :link_libpython wrapper.

Proposed fix

Acceptance

  • a forced wrapper build failure on a machine with a linkable Python fails test_pyo3_wrapper.jl instead of skipping;
  • on a machine without a linkable Python the testsets still skip with an informative message;
  • docs/src/pyo3.md "What a :link_libpython build needs from the machine" and CLAUDE.md are updated to say the skip is now the prerequisite check only.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:ciCI workflows, test-suite infrastructure, lintsarea:pyo3PyO3 crate scanning and #[julia_pyo3]tech-debtAccumulated design or implementation shortcuts that should be repaid

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions