From 8bae9fdb2b108f735d5e660fc63fe779acba5330 Mon Sep 17 00:00:00 2001 From: Andrew Heald Date: Sun, 15 Nov 2015 03:33:02 +0000 Subject: [PATCH 1/4] Remove run-time chef_gem warnings. See notes on compile_time at https://docs.chef.io/resource_chef_gem.html#properties. --- recipes/default.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/recipes/default.rb b/recipes/default.rb index 41929df..7a86d40 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -19,7 +19,9 @@ include_recipe 'chef_handler' -chef_gem 'hipchat' +chef_gem 'hipchat' do + compile_time false if respond_to?(:compile_time) +end handler_file = File.join(node['chef_handler']['handler_path'], 'hipchat_handler.rb') From c848d72943d8c05645473c81fafcadd299fea0eb Mon Sep 17 00:00:00 2001 From: Andrew Heald Date: Mon, 2 May 2016 11:10:38 +0100 Subject: [PATCH 2/4] Update gems. --- Gemfile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Gemfile b/Gemfile index ef70148..f9b9f71 100644 --- a/Gemfile +++ b/Gemfile @@ -1,15 +1,15 @@ source 'https://rubygems.org' gem 'rake' -gem 'berkshelf', '~> 3.3.0' +gem 'berkshelf', '~> 4.3.0' gem 'stove' group :test do - gem 'foodcritic', '~> 4.0.0' - gem 'rubocop', '~> 0.33.0' + gem 'foodcritic', '~> 6.0.1' + gem 'rubocop', '~> 0.38.0' end group :integration do - gem 'test-kitchen', '~> 1.4.2' - gem 'kitchen-vagrant', '~> 0.18.0' + gem 'test-kitchen', '~> 1.7.2' + gem 'kitchen-vagrant', '~> 0.20.0' end From 06904992dfac4d3e0c23d4cba0d56323c94eb2e8 Mon Sep 17 00:00:00 2001 From: Andrew Heald Date: Mon, 2 May 2016 11:17:12 +0100 Subject: [PATCH 3/4] Update rubocop trailing comma rules. --- .rubocop.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index 5cdaff6..de151c8 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -22,7 +22,9 @@ MethodLength: Enabled: false SignalException: Enabled: false -TrailingComma: +TrailingCommaInLiteral: + Enabled: false +TrailingCommaInArguments: Enabled: false WordArray: Enabled: false From 63979d19dc5be78cb54e5859698f2b6f87619fa9 Mon Sep 17 00:00:00 2001 From: Andrew Heald Date: Mon, 2 May 2016 11:29:18 +0100 Subject: [PATCH 4/4] String build tweak to fix another rubocop rule violation. --- files/default/hipchat_handler.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/files/default/hipchat_handler.rb b/files/default/hipchat_handler.rb index d6922fb..fcc0d53 100644 --- a/files/default/hipchat_handler.rb +++ b/files/default/hipchat_handler.rb @@ -68,7 +68,7 @@ def hipchat_emoji if @emoji_url.nil? '' else - %(#{' '}) + " " end end