From 4305234274799a068164083cf25701f51af9fa03 Mon Sep 17 00:00:00 2001
From: Rasmus Bertelsen <rasmusmbertelsen@gmail.com>
Date: Wed, 22 Jul 2026 21:13:58 +0200
Subject: [PATCH] Adding dynamic ADS notification size

Make it possible to receive ADS notifications with a dynamic size, instead of a fixed buffer size.
This helps if you want to subscribe to the EventLogger publisher.
---
 AdsLib/AdsNotification.h                     | 20 ++++++++++++++------
 AdsLib/standalone/NotificationDispatcher.cpp |  8 ++++----
 2 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/AdsLib/AdsNotification.h b/AdsLib/AdsNotification.h
index 41b843f2..29832a6a 100644
--- a/AdsLib/AdsNotification.h
+++ b/AdsLib/AdsNotification.h
@@ -6,6 +6,7 @@
 #pragma once
 
 #include "AdsDef.h"
+#include "Log.h"
 #include "RingBuffer.h"
 
 #include <vector>
@@ -21,6 +22,7 @@ struct Notification {
 		, callback(__func)
 		, buffer(sizeof(AdsNotificationHeader) + length)
 		, hUser(__hUser)
+		, bufferLength(length)
 	{
 		auto header = reinterpret_cast<AdsNotificationHeader *>(
 			buffer.data());
@@ -28,23 +30,28 @@ struct Notification {
 		header->cbSampleSize = length;
 	}
 
-	void Notify(uint64_t timestamp, RingBuffer &ring)
+	void Notify(uint64_t timestamp, RingBuffer &ring, uint32_t size)
 	{
+		if (size > bufferLength)
+		{
+			LOG_ERROR("Notification size exceeds buffer. "
+					<< size << " > " << bufferLength);
+			return;
+		}
 		auto header = reinterpret_cast<AdsNotificationHeader *>(
 			buffer.data());
 		uint8_t *data = reinterpret_cast<uint8_t *>(header + 1);
-		for (size_t i = 0; i < header->cbSampleSize; ++i) {
+		for (size_t i = 0; i < size; ++i) {
 			data[i] = ring.ReadFromLittleEndian<uint8_t>();
 		}
 		header->nTimeStamp = timestamp;
+		header->cbSampleSize = size;
 		callback(&connection.second, header, hUser);
 	}
 
-	uint32_t Size() const
+	uint32_t Capacity() const
 	{
-		auto header = reinterpret_cast<const AdsNotificationHeader *>(
-			buffer.data());
-		return header->cbSampleSize;
+		return bufferLength;
 	}
 
 	void hNotify(uint32_t value)
@@ -58,4 +65,5 @@ struct Notification {
 	const PAdsNotificationFuncEx callback;
 	std::vector<uint8_t> buffer;
 	const uint32_t hUser;
+	const uint32_t bufferLength;
 };
diff --git a/AdsLib/standalone/NotificationDispatcher.cpp b/AdsLib/standalone/NotificationDispatcher.cpp
index 8d3998c7..b73c21f9 100644
--- a/AdsLib/standalone/NotificationDispatcher.cpp
+++ b/AdsLib/standalone/NotificationDispatcher.cpp
@@ -80,15 +80,15 @@ void NotificationDispatcher::Run()
 				fullLength -= sizeof(hNotify) + sizeof(size);
 				const auto notification = Find(hNotify);
 				if (notification) {
-					if (size != notification->Size()) {
+					if (size > notification->Capacity()) {
 						LOG_WARN(
 							"Notification sample size: "
 							<< size
-							<< " doesn't match: "
-							<< notification->Size());
+							<< " exceeds buffer: "
+							<< notification->Capacity());
 						goto cleanup;
 					}
-					notification->Notify(timestamp, ring);
+					notification->Notify(timestamp, ring, size);
 				} else {
 					ring.Read(size);
 				}