Issues with spaces in paths

[rooklift]

It seems Sayuri (on Windows, anyway) cannot launch if its path contains any spaces.

Also, I believe it cannot load weights if the location of the weights contains any spaces.

[CGLemon]

Thanks. I check this issue. The engine can not load path including space on the Command Prompt. However, I don't think it is a bug? should have a way to input the whole path string?

[rooklift]

Well:

PS C:\Users\Owner\Documents\Misc\sayuri-v0.7.0-cuda12 windows-x64> .\sayuri-v0.7.0-cuda12-windows-x64.exe
Command(s) Error:
 are not understood.

I'm not doing anything except launch it. You can reproduce this just by double-clicking the exe, if its path has a space, it will quit instantly, whereas without a space, you can enter the GTP console at least.

[rooklift]

I'm no C++ person, but it seems like these lines:

Sayuri/src/utils/splitter.cc

Lines 13 to 19 in 25e262c

	Splitter::Splitter(int argc, char** argv) {
	auto oss = std::ostringstream{};
	for (int i = 0; i < argc; ++i) {
	oss << argv[i] << " ";
	}
	Parse(std::forward<std::string>(oss.str()), kMaxBufferSize);
	}

are merging the various argv strings, including argv[0]

so e.g. if you have these arguments:

[0] some path with spaces/sayuri.exe
[1] -w
[2] some path with spaces/weights.txt

it will merge all this into a single space-separated string, which it can no longer parse, since it can't tell where one arg ends and another begins?

[CGLemon]

I did not notice that. Thanks for your help.

[CGLemon]

Fix this bug at next branch and test it on the Ubuntu. It works well now.