Skip to content

Build fails: RuleEngineBase.sol imports CMTAT/library/RuleEngineInterfaceId.sol and CMTAT/library/ERC1404ExtendInterfaceId.sol but those files don't exist anywhere in any tag/branch (v3.0.0 audited release) #66

Description

@fernandoverboonen-eng

Bug: CMTAT/library/RuleEngineInterfaceId and CMTAT/library/ERC1404ExtendInterfaceId import paths do not resolve

Versions

  • CMTA/CMTAT tag v3.0.0 (the audited release, Wake Arena M1/M2/M3)
  • CMTA/RuleEngine tag v3.0.0-rc4
  • OpenZeppelin contracts v4.9.x
  • OpenZeppelin contracts-upgradeable v4.9.x

Reproduction

cd /tmp && mkdir cmt-repro && cd cmt-repro
git clone --depth=1 -b v3.0.0 https://github.com/CMTA/CMTAT.git
git clone --depth=1 -b v3.0.0-rc4 https://github.com/CMTA/RuleEngine.git
cd RuleEngine && forge build

Compiler output

Error: Source "CMTAT/library/ERC1404ExtendInterfaceId.sol" not found
Error: Source "CMTAT/library/RuleEngineInterfaceId.sol" not found
   --> RuleEngineBase.sol:8:
   --> RuleEngineBase.sol:9:

Root cause

The imports in RuleEngineBase.sol reference:

  • CMTAT/library/ERC1404ExtendInterfaceId.sol (singular path, "ERC1404Extend" name)
  • CMTAT/library/RuleEngineInterfaceId.sol (singular path, "RuleEngine" name)

But the actual files in RuleEngine/src/modules/library/ are:

  • ERC1404InterfaceId.sol (no "Extend")
  • RuleInterfaceId.sol (no "Engine")

Either the Base is stale or the library library has been renamed since. I verified this consistently across all tags and branches (main and dev are at identical commits, no rebrand history).

I am using your tag pinned releases to keep the audit lineage. Without this fix, no third party can build a working integration against the audited v3.0.0 release.

I would be grateful for either:

  • A patched v3.0.x point release that fixes these imports, or
  • An official reply with which version pairing IS known-good

My work-in-progress: I have a working SwissDLTComplianceRule that needs to plug into RuleEngineBase. With the import bug fixed, integration tests should be straightforward.

Thanks

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions