Skip to content

Python drivers for graphite-web are not compatible with python 3 #98

Description

@TH-HA

New version of graphite-web is now supporting python 3.
I ve tried to setup everything and i was unable to display any data.
After looking in the driver ( and spending some time , i'm not a python dev , so apology if the vocabulary is not correct ) , i 've found 2 blocking issue in graphouse.py
1: in the init method of the graphouseReader, the way to detect if we have a collection or a string is not working ( hasattr(path, 'iter') is returning true on string , so it breaks everything, using something like isinstance(obj, collections.Sequence) should solve the issue )
2 : The fetch method is now taking 5 parameters instead of 3 ( self, start,stop,now,requestContext).

By fixing those 2 issues , i was able to make things work. But as i ve starting to learn python during the troubleshooting i don't feel really confortable to propose a fix.

Regards

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions