Skip to content

Vanilla relative filters #53

Description

@roeysc

Consider adding another filter in the FeatureExtractor.py, for excluding games with too many gallery shapes.
Currently Both Yogev and Roey are using such a filter downstream (e.g., before running Pareto), but that isn't the right way to go, because all the relative features are calculated relative to the vanilla dataset that does include these bad games.
This change would require adding a mask in FeatureExtractor._get_sample_relative_filters, as well as relevant constants in behavioral._consts. The default_config.yml can stay the same assuming that we use the same threshold of 3 Z-scores.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions