Skip to content

MultiGameDataRetriever uses default events file name #66

Description

@danamir1

MultiGameDataRetriever doesn't use the output_filename as the rest of the retrievers in the Pipeline construction.
Should be added as an argument to the __init__ function and used properly with the line:

if self._is_multi_game_request(): return MultiGameDataRetriever( base_retriever_constructor=factory, config=self.config, logger=self.logger, )
to be replaced with:
if self._is_multi_game_request(): return MultiGameDataRetriever( base_retriever_constructor=factory, config=self.config, logger=self.logger, output_filename=self.output_filename, )
At the same time, we also want to update the pipeline script help messages, to indicate that game_id can be a comma-separated list of games.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions