Goal
plot.owsa(col = "bw") maps linetype through aes_(), which eagerly evaluates its arguments in the function environment where strategy <- NULL was set to silence R CMD check. linetype therefore maps to NULL rather than the data column, so every strategy receives the same linetype and collapses into one indistinguishable line on a documented, vignette-used argument.
Scope
- Replace
aes_(linetype = strategy) with aes(linetype = strategy) at R/owsa.R:129
- Switch the deprecated
size argument to linewidth in the same call
- Add a regression test asserting one distinct linetype and one group per strategy in the
bw branch
- Confirm the
col = "full" branch is unchanged
Version: #172
Goal
plot.owsa(col = "bw")mapslinetypethroughaes_(), which eagerly evaluates its arguments in the function environment wherestrategy <- NULLwas set to silence R CMD check.linetypetherefore maps toNULLrather than the data column, so every strategy receives the same linetype and collapses into one indistinguishable line on a documented, vignette-used argument.Scope
aes_(linetype = strategy)withaes(linetype = strategy)atR/owsa.R:129sizeargument tolinewidthin the same callbwbranchcol = "full"branch is unchangedVersion: #172