From 6578752636e505c1f984a47d2a4d0bd70cd5ad93 Mon Sep 17 00:00:00 2001 From: jakeross Date: Tue, 25 Aug 2026 09:16:42 -0700 Subject: [PATCH] fix(chemistry): restore the return in manifest_overview Copilot Autofix pushed three commits straight to staging against PR #892. The last of them (cbd5a5aa) re-added the per-file merge block but deleted `return overview`, so manifest_overview() built the overview and returned None. That broke `oco water-chemistry manifest-status` and failed test_manifest_overview_merges_databases and test_manifest_overview_separates_corrupt_manifest. The findings those commits were answering did not hold against the code as merged in #886: the merge block was already correctly scoped inside the `for db` loop, and the non-dict manifest guard was already present. The net effect of the autofix run was to remove a working return statement. Restore it. tests/test_chemistry_drive.py (17) and tests/test_chemistry_lims.py (30) pass. Co-Authored-By: Claude Opus 5 --- services/chemistry_drive.py | 1 + 1 file changed, 1 insertion(+) diff --git a/services/chemistry_drive.py b/services/chemistry_drive.py index d64763f6..225f34d9 100644 --- a/services/chemistry_drive.py +++ b/services/chemistry_drive.py @@ -286,6 +286,7 @@ def manifest_overview(bucket=None) -> ManifestOverview: if entry.get("name"): record["name"] = entry["name"] record["databases"][db] = entry + return overview # --- orchestration -------------------------------------------------------------