Skip to content

collab-client-marks-preservation.test.ts imports an export that does not exist #75

Description

@rclod

src/tests/collab-client-marks-preservation.test.ts fails to load on a clean checkout of main:

SyntaxError: The requested module "../bridge/marks-preservation" does not provide an export named "shouldIgnoreIncomingEmptyServerMarks"

src/bridge/marks-preservation.ts exports only shouldPreserveMissingLocalMark, and shouldIgnoreIncomingEmptyServerMarks is not defined anywhere else in the repo — the identifier appears solely in that test file.

The test never runs, so the six assertions it makes about empty-server-marks handling are not protecting anything. It is not caught by CI because npm test only runs proof-sdk-agent-bridge-client and server-routes-and-share; the other 131 files under src/tests/ are standalone tsx entrypoints that nothing invokes as a suite.

I have not guessed at the intended semantics, so no PR here — either the helper was dropped during a refactor and needs restoring, or the test should go. Flagging it because it is one of the natural homes for mark-preservation coverage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions