Skip to content

Muons: Tpar editor (nice to have) improvements #8991

Description

@GRyall

Issue Description

As a muon scientist I would like to make it even harder for my users to muck up the TPar file.

How & Where?

This follows on from #8990 and covers the nice to have elements of what was requested by the muon group.

Additional Information

  • The format of the TPar file is constant, though the number of lines varies
  • There are two TPar files used the regular one and the booster one
  • The set temperature script and possibly script generator consume the tpar file
  • There is currently a tpar editor as a device screen in the GUI
  • Not every instrument wants to expose tpar editing to it's users
  • A valid TPar file:
    • containers a header. This is never changed
    • Has a constant number of columns
    • THigh is the TLow of the next line
    • has at least one line that is not header

See our Git Workflow.

Acceptance Criteria

  • We validate TPAR files edited in the editor (see above) before allowing them to be saved
  • We present the data in the editor as a table for editing, rather than a text file

How to Review

Before making a PR...

  • Provide verbose instructions for the reviewer to test that your changes work and fix the issue
  • Describe if/how you have implemented testing for this issue
  • Provide screenshots of the feature to help the reviewer if relevant

If not applicable, write "Not applicable"

...

To the reviewer: Make sure to update submodules!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions