Skip to content

Commit 9210943

Browse files
martonaReenigneArcher
authored andcommitted
sonar override clarification
1 parent af170ba commit 9210943

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/macos/mac_display_device_general.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ namespace display_device {
5858
}
5959

6060
// Keep braced aggregate construction; emplace_back(args...) relies on parenthesized aggregate init, which older libc++ rejects.
61-
devices.push_back(EnumeratedDevice {device_id, display_name, friendly_name, edid, info}); // NOSONAR
61+
devices.push_back(EnumeratedDevice {device_id, display_name, friendly_name, edid, info}); // NOSONAR(cpp:S6003): Direct emplace_back args fail on older toolchains
6262
}
6363

6464
return devices;

src/windows/win_display_device_general.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,10 @@ namespace display_device {
7070
};
7171

7272
// Keep braced aggregate construction; emplace_back(args...) relies on parenthesized aggregate init, which older libc++ rejects.
73-
available_devices.push_back(EnumeratedDevice {device_id, display_name, friendly_name, edid, info}); // NOSONAR
73+
available_devices.push_back(EnumeratedDevice {device_id, display_name, friendly_name, edid, info}); // NOSONAR(cpp:S6003): Direct emplace_back args fail on older toolchains
7474
} else {
7575
// Keep braced aggregate construction; emplace_back(args...) relies on parenthesized aggregate init, which older libc++ rejects.
76-
available_devices.push_back(EnumeratedDevice {device_id, display_name, friendly_name, edid, std::nullopt}); // NOSONAR
76+
available_devices.push_back(EnumeratedDevice {device_id, display_name, friendly_name, edid, std::nullopt}); // NOSONAR(cpp:S6003): Direct emplace_back args fail on older toolchains
7777
}
7878
}
7979

0 commit comments

Comments
 (0)