diff --git a/app/models/hold.rb b/app/models/hold.rb index ceece1bb..0cc2211f 100644 --- a/app/models/hold.rb +++ b/app/models/hold.rb @@ -36,7 +36,9 @@ class Hold < ApplicationRecord validates :date_requested, presence: true validates :date_start, presence: true validates :date_end, presence: true + validates :hold_source, presence: true validates :status, presence: true + validates :thesis, presence: true after_save :update_thesis_status diff --git a/test/models/hold_test.rb b/test/models/hold_test.rb index 90395222..4d7cde5d 100644 --- a/test/models/hold_test.rb +++ b/test/models/hold_test.rb @@ -43,6 +43,24 @@ class HoldTest < ActiveSupport::TestCase assert(hold.invalid?) end + test 'invalid without thesis' do + hold = holds(:valid) + assert hold.thesis.present? + assert hold.valid? + + hold.thesis = nil + assert_not hold.valid? + end + + test 'invalid without hold source' do + hold = holds(:valid) + assert hold.hold_source.present? + assert hold.valid? + + hold.hold_source = nil + assert_not hold.valid? + end + test 'valid date_start' do hold = holds(:valid) assert(hold.valid?)