Skip to content

Make tests for non-singularity of matrices more robust #7

Description

@tabpeter

This is issue 59 in previous repository.

We drafted a test for get_An():

test_that("getAn is non-singular (invertible) for IPW estimation", {
   ...
})

Notice that this still allows an ill-conditioned (nearly singular) matrix to pass. This can be a low priority issue, as An can be positive semi-definite -- this can occur if the regression models used as Q-functions have collinearity. Still, we may need to enhance this test as a guardrail.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions