Skip to content

aerosol_gas_tables calls Inside_SE, which is not defined anywhere #475

Description

@brianpm

What happens

aerosol_gas_tables calls Inside_SE, which is not defined anywhere in the
repository:

# scripts/analysis/aerosol_gas_tables.py, line 301
if regional:
    #inside = Inside_SE_region(current_lat,current_lon,dir_shapefile)
    inside = Inside_SE(Lats,Lons,limit)

So the regional path raises NameError: name 'Inside_SE' is not defined as
soon as anyone uses it. A comment on the line above already says the function
is "unavailable at the moment".

How to reach it

regional comes from the budget_tables section of the variable defaults,
where it is False (lib/adf_variable_defaults.yaml, line 2668), so the path
is not reached by default. Setting regional: True, which is what the setting
is for, hits it immediately. limit is set just above it and is only used by
this call.

Where

  • scripts/analysis/aerosol_gas_tables.py, line 301 (the call), lines 145-146
    (limit and regional read from the defaults).
  • lib/adf_variable_defaults.yaml, lines 2667-2668 (limit, regional).

Worth deciding

Either the function should be restored, or the option should be removed until
it is, so that a setting the ADF offers does not fail when used. The file also
marks the section "### NOT WORKING FOR NOW" at line 142, which suggests the
second is closer to the intent.

Details

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions