Skip to content

Wire the docker-compose-based tests into CI #383

Description

@gaurav

The new .github/workflows/test.yml runs the headless tests: the unit suite plus a loader integration test that starts a real Redis with testcontainers. Two test files are excluded because they use an older harness:

  • tests/test_endpoints.py and tests/test_callback.py build and start the full app via tests/conftest.py's session fixture, which shells out to the legacy docker-compose v1 binary (testcontainers==3.6.1 DockerCompose) against docker-compose-test.yml. This needs the full app image built and the v1 CLI, and test_async_query_callback currently errors even locally.

Work to do:

  • Port these to a CI-friendly setup (either docker compose v2 / a newer testcontainers, or restructure them to use testcontainers.redis.RedisContainer + an in-process app the way tests/test_loader_integration.py does).
  • Deal with the fact that tests/test_norm.py and tests/test_setid.py assign to app.state.* at import time, which makes a full unmarked pytest run order-dependent.
  • Then drop the --ignore flags from the CI workflow.

Context: .github/workflows/test.yml, tests/conftest.py, tests/test_loader_integration.py (the pattern to follow).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions