Severity: minor (reproducibility + offline failure)
Where: nhflotools/polder.py:40 — regional polder drainage (the default branch, since polders_in_detail=False) is built from a live, unversioned download from HHNK's ArcGIS server with TLS verification disabled (verify=False) and no caching.
Problem. A registered, versioned peilgebieden_hhnk dataset exists in NHFLO/data but is unused. Offline runs crash; service-side peilgebieden updates silently change model results between runs; and verify=False disables certificate checking.
Suggested fix. Read peilgebieden from the versioned nhflodata dataset (get_abs_data_path("peilgebieden_hhnk", ...)) and keep the live download as an explicit refresh path; at minimum drop verify=False and cache the downloaded GeoDataFrame. (Coordinates with the NHFLO/data issue on sourcing peilgebieden from the versioned dataset.)
From a systematic review of modelscripts/09pwnmodel2/01_pwnmodel2.py and its dependency stack (nhflotools, nhflodata, nlmod), July 2026. Every finding was traced through the actual code and adversarially verified before filing.
Severity: minor (reproducibility + offline failure)
Where:
nhflotools/polder.py:40— regional polder drainage (the default branch, sincepolders_in_detail=False) is built from a live, unversioned download from HHNK's ArcGIS server with TLS verification disabled (verify=False) and no caching.Problem. A registered, versioned
peilgebieden_hhnkdataset exists in NHFLO/data but is unused. Offline runs crash; service-side peilgebieden updates silently change model results between runs; andverify=Falsedisables certificate checking.Suggested fix. Read peilgebieden from the versioned nhflodata dataset (
get_abs_data_path("peilgebieden_hhnk", ...)) and keep the live download as an explicit refresh path; at minimum dropverify=Falseand cache the downloaded GeoDataFrame. (Coordinates with the NHFLO/data issue on sourcing peilgebieden from the versioned dataset.)From a systematic review of
modelscripts/09pwnmodel2/01_pwnmodel2.pyand its dependency stack (nhflotools, nhflodata, nlmod), July 2026. Every finding was traced through the actual code and adversarially verified before filing.