diff --git a/AsyncImageView/AsyncImageView.swift b/AsyncImageView/AsyncImageView.swift index 8c41a6a..0546fc9 100644 --- a/AsyncImageView/AsyncImageView.swift +++ b/AsyncImageView/AsyncImageView.swift @@ -38,7 +38,6 @@ open class AsyncImageView< private let requestsObserver: Signal.Observer private let imageCreationScheduler: ReactiveSwift.Scheduler - private let animatesImageChanges: Bool private var disposable: Disposable? @@ -47,12 +46,10 @@ open class AsyncImageView< renderer: Renderer, placeholderRenderer: PlaceholderRenderer? = nil, uiScheduler: ReactiveSwift.Scheduler = UIScheduler(), - imageCreationScheduler: ReactiveSwift.Scheduler = QueueScheduler(), - animatesImageChanges: Bool = true + imageCreationScheduler: ReactiveSwift.Scheduler = QueueScheduler() ) { (self.requestsSignal, self.requestsObserver) = Signal.pipe() self.imageCreationScheduler = imageCreationScheduler - self.animatesImageChanges = animatesImageChanges super.init(frame: initialFrame) @@ -127,7 +124,7 @@ open class AsyncImageView< private func updateImage(_ result: Renderer.RenderResult?) { if let result = result { - if result.cacheHit || !self.animatesImageChanges { + if result.cacheHit { self.image = result.image } else { UIView.transition( diff --git a/AsyncImageViewTests/AsyncImageViewTests.swift b/AsyncImageViewTests/AsyncImageViewTests.swift index 024206c..610475a 100644 --- a/AsyncImageViewTests/AsyncImageViewTests.swift +++ b/AsyncImageViewTests/AsyncImageViewTests.swift @@ -41,19 +41,6 @@ struct AsyncImageViewBehaviorTests { await fixture.verifyRenderedImage() } - @Test - func canDisableImageChangeAnimations() async { - let fixture = ImageViewFixture( - size: CGSize(width: 10, height: 10), - animatesImageChanges: false - ) - - fixture.view.data = .a - - await fixture.verifyRenderedImage() - #expect(fixture.view.layer.animationKeys()?.isEmpty != false) - } - @Test func updatingDataUpdatesImage() async { let fixture = ImageViewFixture(size: CGSize(width: 10, height: 10)) @@ -250,18 +237,13 @@ private final class ImageViewFixture { let view: ViewType private let window = UIWindow() - init( - size: CGSize = .zero, - data: TestData? = nil, - animatesImageChanges: Bool = true - ) { + init(size: CGSize = .zero, data: TestData? = nil) { self.view = ViewType( initialFrame: CGRect(origin: .zero, size: size), renderer: self.renderer, placeholderRenderer: nil, uiScheduler: QueueScheduler(targeting: DispatchQueue.main), - imageCreationScheduler: ImmediateScheduler(), - animatesImageChanges: animatesImageChanges + imageCreationScheduler: ImmediateScheduler() ) self.window.addSubview(self.view) self.view.data = data