Skip to content

New-comment Ask has two gaps: unified view never offers it, and no unheard notice after sending #73

Description

@fiddur

Two related gaps around asking the agent from a new comment form (found while reviewing #69, both pre-existing):

  1. Unified view: hunk-block.tsx destructures onAskThread/onActThread but never passes them to its CommentFormRow, so the unified diff view offers no Ask/Act on new comments at all — the split view does (hunk-block-split.tsx wires them).

  2. No unheard notice on new-thread asks: when nobody is listening, a reply-Ask pops the "No agent is connected" UnheardNotice on the thread card. A new-comment Ask (anchored or general) only has the pre-press tooltip; after pressing, the form closes and the fresh thread card mounts silently — unheard-request.ts's own header names tooltip-only as the failure mode ("nobody hovers before pressing. Silence reads as sent").

Fix direction: wire the unified-view props, and give the new-thread path the same post-press notice the reply path has (e.g. the thread card a new ask becomes shows the notice on mount when askIsHeard was false at send time).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions