From c0a5cff185fe4b282fec4d6a358f92a25399bfe2 Mon Sep 17 00:00:00 2001 From: Raphael Mobis Tacla Date: Thu, 3 Sep 2026 01:33:58 -0300 Subject: [PATCH 1/9] test --- .github/workflows/fix-and-lint.yml | 110 +++++++++++++++-------------- 1 file changed, 58 insertions(+), 52 deletions(-) diff --git a/.github/workflows/fix-and-lint.yml b/.github/workflows/fix-and-lint.yml index 10bc381..ab2f323 100644 --- a/.github/workflows/fix-and-lint.yml +++ b/.github/workflows/fix-and-lint.yml @@ -5,12 +5,12 @@ on: branches: ["main"] jobs: - check-sensitive: - name: Check for Sensitive Files + check-prereqs: + name: Check for Prerequisites runs-on: ubuntu-latest outputs: - require_approval: ${{ steps.changed-sensitive.outputs.any_changed || false }} + require_approval: ${{ steps.check-sensitive.outputs.any_changed || false }} skip_fix: ${{ contains(steps.skip-fix.outputs.commit_message, 'skip-fix') }} steps: @@ -23,7 +23,7 @@ jobs: allow-unsafe-pr-checkout: true - name: Check Changed Sensitive Files - id: changed-sensitive + id: check-sensitive if: github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name uses: tj-actions/changed-files@v47 with: @@ -36,25 +36,45 @@ jobs: - name: Get Latest Commit Message id: skip-fix run: | - git log echo 'commit_message<> $GITHUB_OUTPUT git log -1 --pretty=%B ${{ github.event.pull_request.head.sha }} >> $GITHUB_OUTPUT echo 'EOF' >> $GITHUB_OUTPUT + request-approval: + name: Request Approval + runs-on: ubuntu-latest + environment: Require Approval + needs: check-prereqs + if: needs.check-prereqs.outputs.require_approval != 'false' + + steps: + - name: Approval Received + run: echo 'Approved' + + safety-gate: + name: Safety Gate + runs-on: ubuntu-latest + needs: [check-prereqs, request-approval] + if: | + always() && + needs.check-prereqs.result == 'success' && + (needs.check-prereqs.outputs.require_approval == 'false' || needs.request-approval.result == 'success') + + steps: + - name: Gate Passed + run: echo 'Passed' + fix: name: Fix runs-on: ubuntu-latest - needs: check-sensitive + needs: [safety-gate, check-prereqs] if: | - always() && - needs.check-sensitive.outputs.skip_fix != 'true' && - needs.check-sensitive.outputs.require_approval == 'false' + needs.safety-gate.result == 'success' && + needs.check-prereqs.result == 'success' && + needs.check-prereqs.outputs.skip_fix != 'true' outputs: - changes_detected: ${{ steps.fix-stuff.outputs.changes_detected }} - - permissions: - contents: write + skip_lint: ${{ steps.commit-changes.outputs.changes_detected }} steps: - name: Checkout repository @@ -64,49 +84,41 @@ jobs: repository: ${{ github.event.pull_request.head.repo.full_name }} ref: ${{ github.head_ref }} allow-unsafe-pr-checkout: true + - uses: ./.github/actions/setup - - name: Fix Stuff - id: fix-stuff - uses: ./.github/actions/fix-stuff + - name: Format Code + shell: bash + run: npm run format + + - name: Generate UUIDs + shell: bash + run: npm run gen:uuids + + - name: Commit Changes + id: commit-changes + uses: stefanzweifel/git-auto-commit-action@v7 with: commit_author: "${{ github.event.pull_request.user.login }} <${{ github.event.pull_request.user.login }}+${{ github.event.pull_request.user.id }}@users.noreply.github.com>" + commit_user_name: osrs-taskbot + commit_user_email: r.mobis+taskbot@gmail.com + commit_message: "[skip-fix] format and generate missing UUIDs" - fix-sensitive: - name: Fix (Sensitive) + lint-gate: + name: Lint Gate runs-on: ubuntu-latest - environment: Require Approval - needs: check-sensitive + needs: [safety-gate, fix] if: | always() && - needs.check-sensitive.outputs.require_approval != 'false' - - outputs: - changes_detected: false - - permissions: - contents: write + needs.safety-gate.result == 'success' && + needs.fix.outputs.skip_lint != 'true' steps: - - name: Checkout repository - uses: actions/checkout@v7 - with: - token: ${{ secrets.ROBOT_GITHUB_TOKEN }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - ref: ${{ github.head_ref }} - allow-unsafe-pr-checkout: true - - - name: Fix Stuff - id: fix-stuff - uses: ./.github/actions/fix-stuff - with: - commit_author: "${{ github.event.pull_request.user.login }} <${{ github.event.pull_request.user.login }}+${{ github.event.pull_request.user.id }}@users.noreply.github.com>" + - name: Gate Passed + run: echo 'Passed' lint: name: General Linting - needs: [fix, fix-sensitive] - if: | - always() && - needs.fix.outputs.changes_detected != 'true' && needs.fix-sensitive.outputs.changes_detected != 'true' + needs: lint-gate runs-on: ubuntu-latest steps: @@ -129,10 +141,7 @@ jobs: lint-links: name: Link Links - needs: [fix, fix-sensitive] - if: | - always() && - needs.fix.outputs.changes_detected != 'true' && needs.fix-sensitive.outputs.changes_detected != 'true' + needs: lint-gate runs-on: ubuntu-latest steps: @@ -154,10 +163,7 @@ jobs: check-types: name: Check Typescript Types - needs: [fix, fix-sensitive] - if: | - always() && - needs.fix.outputs.changes_detected != 'true' && needs.fix-sensitive.outputs.changes_detected != 'true' + needs: lint-gate runs-on: ubuntu-latest steps: From 9b7b7e2fcf5b42d727c4182ea9acf9e1b1e98f4b Mon Sep 17 00:00:00 2001 From: Raphael Mobis Tacla Date: Thu, 3 Sep 2026 01:45:42 -0300 Subject: [PATCH 2/9] test --- .github/workflows/fix-and-lint.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/fix-and-lint.yml b/.github/workflows/fix-and-lint.yml index ab2f323..6bc607d 100644 --- a/.github/workflows/fix-and-lint.yml +++ b/.github/workflows/fix-and-lint.yml @@ -119,6 +119,9 @@ jobs: lint: name: General Linting needs: lint-gate + if: | + always() && + needs.lint-gate.result == 'success' runs-on: ubuntu-latest steps: @@ -142,6 +145,9 @@ jobs: lint-links: name: Link Links needs: lint-gate + if: | + always() && + needs.lint-gate.result == 'success' runs-on: ubuntu-latest steps: @@ -164,6 +170,9 @@ jobs: check-types: name: Check Typescript Types needs: lint-gate + if: | + always() && + needs.lint-gate.result == 'success' runs-on: ubuntu-latest steps: From 4e6d168d12c24208f700da2f04e15dad3255d05e Mon Sep 17 00:00:00 2001 From: Raphael Mobis Tacla Date: Thu, 3 Sep 2026 01:48:36 -0300 Subject: [PATCH 3/9] testo --- .github/workflows/fix-and-lint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/fix-and-lint.yml b/.github/workflows/fix-and-lint.yml index 6bc607d..39e5396 100644 --- a/.github/workflows/fix-and-lint.yml +++ b/.github/workflows/fix-and-lint.yml @@ -69,6 +69,7 @@ jobs: runs-on: ubuntu-latest needs: [safety-gate, check-prereqs] if: | + always() && needs.safety-gate.result == 'success' && needs.check-prereqs.result == 'success' && needs.check-prereqs.outputs.skip_fix != 'true' From 29f6ca2eea82090a61c473e68b6826fb0b148e4b Mon Sep 17 00:00:00 2001 From: Raphael Mobis Tacla Date: Thu, 3 Sep 2026 01:55:22 -0300 Subject: [PATCH 4/9] testoo --- .github/workflows/fix-and-lint.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/fix-and-lint.yml b/.github/workflows/fix-and-lint.yml index 39e5396..4b08162 100644 --- a/.github/workflows/fix-and-lint.yml +++ b/.github/workflows/fix-and-lint.yml @@ -7,7 +7,7 @@ on: jobs: check-prereqs: name: Check for Prerequisites - runs-on: ubuntu-latest + runs-on: ubuntu-slim outputs: require_approval: ${{ steps.check-sensitive.outputs.any_changed || false }} @@ -42,7 +42,7 @@ jobs: request-approval: name: Request Approval - runs-on: ubuntu-latest + runs-on: ubuntu-slim environment: Require Approval needs: check-prereqs if: needs.check-prereqs.outputs.require_approval != 'false' @@ -53,12 +53,12 @@ jobs: safety-gate: name: Safety Gate - runs-on: ubuntu-latest + runs-on: ubuntu-slim needs: [check-prereqs, request-approval] if: | always() && needs.check-prereqs.result == 'success' && - (needs.check-prereqs.outputs.require_approval == 'false' || needs.request-approval.result == 'success') + (needs.request-approval.result == 'success' || needs.check-prereqs.outputs.require_approval == 'false') steps: - name: Gate Passed @@ -66,7 +66,7 @@ jobs: fix: name: Fix - runs-on: ubuntu-latest + runs-on: ubuntu-slim needs: [safety-gate, check-prereqs] if: | always() && @@ -106,7 +106,7 @@ jobs: lint-gate: name: Lint Gate - runs-on: ubuntu-latest + runs-on: ubuntu-slim needs: [safety-gate, fix] if: | always() && @@ -123,7 +123,7 @@ jobs: if: | always() && needs.lint-gate.result == 'success' - runs-on: ubuntu-latest + runs-on: ubuntu-slim steps: - name: Checkout repository @@ -149,7 +149,7 @@ jobs: if: | always() && needs.lint-gate.result == 'success' - runs-on: ubuntu-latest + runs-on: ubuntu-slim steps: - name: Checkout repository @@ -174,7 +174,7 @@ jobs: if: | always() && needs.lint-gate.result == 'success' - runs-on: ubuntu-latest + runs-on: ubuntu-slim steps: - name: Checkout repository From 968bb2ea3cb8645ff4ed463df31b2d3608811e84 Mon Sep 17 00:00:00 2001 From: Raphael Mobis Tacla Date: Thu, 3 Sep 2026 01:59:07 -0300 Subject: [PATCH 5/9] testu --- .github/workflows/fix-and-lint.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/fix-and-lint.yml b/.github/workflows/fix-and-lint.yml index 4b08162..3d36887 100644 --- a/.github/workflows/fix-and-lint.yml +++ b/.github/workflows/fix-and-lint.yml @@ -24,7 +24,7 @@ jobs: - name: Check Changed Sensitive Files id: check-sensitive - if: github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name + # if: github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name uses: tj-actions/changed-files@v47 with: files: | @@ -48,8 +48,7 @@ jobs: if: needs.check-prereqs.outputs.require_approval != 'false' steps: - - name: Approval Received - run: echo 'Approved' + - run: true safety-gate: name: Safety Gate @@ -61,8 +60,7 @@ jobs: (needs.request-approval.result == 'success' || needs.check-prereqs.outputs.require_approval == 'false') steps: - - name: Gate Passed - run: echo 'Passed' + - run: true fix: name: Fix @@ -114,8 +112,7 @@ jobs: needs.fix.outputs.skip_lint != 'true' steps: - - name: Gate Passed - run: echo 'Passed' + - run: true lint: name: General Linting From c7851abe424e5c20a9e273bc43d4fac0e7aaa267 Mon Sep 17 00:00:00 2001 From: Raphael Mobis Tacla Date: Thu, 3 Sep 2026 01:34:38 -0300 Subject: [PATCH 6/9] test --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 0c3ad3b..3606d82 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ /node_modules /lists + /.cache \ No newline at end of file From fb18bbafc1b907e0378959d54ef9d33c66326599 Mon Sep 17 00:00:00 2001 From: Raphael Mobis Tacla Date: Thu, 3 Sep 2026 01:47:17 -0300 Subject: [PATCH 7/9] im a noobo --- tiers/easy.json | 2 +- tiers/elite.json | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tiers/easy.json b/tiers/easy.json index 8d195bb..2205ea3 100644 --- a/tiers/easy.json +++ b/tiers/easy.json @@ -2431,7 +2431,7 @@ } }, { - "id": "ffc96e1a-1d48-42c4-97f5-a6946bc61379", + "id": "", "name": "Get a Warped sceptre", "shortName": "Warped Sceptre", "tip": "Obtained as a drop from Warped terrorbirds and tortoises. The tortoises can be safespotted in the first room. Requires completion of The Path of Glouphrie quest. Don't forget your crystal chimes! ", diff --git a/tiers/elite.json b/tiers/elite.json index 06d24d6..bffff8a 100644 --- a/tiers/elite.json +++ b/tiers/elite.json @@ -1507,6 +1507,7 @@ "count": 11 } }, + { "id": "0f271100-8134-4cda-a88f-fd92f9c710f6", "name": "Get 1 new unique from elite clues", From 2e4dbaa6299a7c52be3378adc202815d6d1c2b20 Mon Sep 17 00:00:00 2001 From: Raphael Mobis Tacla Date: Thu, 3 Sep 2026 01:59:40 -0300 Subject: [PATCH 8/9] i modify sensitive files too! --- bin/frac.mts | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/frac.mts b/bin/frac.mts index 4c66e7e..db9c475 100644 --- a/bin/frac.mts +++ b/bin/frac.mts @@ -28,6 +28,7 @@ let fileCount = 0, const walker = new Glob(fileGlobs, {}); for await (const file of walker) { fileCount++; + const content = (await readFile(file)).toString(); const formattedContent = fmt.Reformat(content); From f071ba6588635c0c2adc655b9588c49367e8cdb2 Mon Sep 17 00:00:00 2001 From: rmobis Date: Thu, 3 Sep 2026 05:00:25 +0000 Subject: [PATCH 9/9] [skip-fix] format and generate missing UUIDs --- tiers/easy.json | 2 +- tiers/elite.json | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tiers/easy.json b/tiers/easy.json index 2205ea3..2e4f065 100644 --- a/tiers/easy.json +++ b/tiers/easy.json @@ -2431,7 +2431,7 @@ } }, { - "id": "", + "id": "d357e7cc-ceff-431f-850e-58995ecdbbab", "name": "Get a Warped sceptre", "shortName": "Warped Sceptre", "tip": "Obtained as a drop from Warped terrorbirds and tortoises. The tortoises can be safespotted in the first room. Requires completion of The Path of Glouphrie quest. Don't forget your crystal chimes! ", diff --git a/tiers/elite.json b/tiers/elite.json index bffff8a..06d24d6 100644 --- a/tiers/elite.json +++ b/tiers/elite.json @@ -1507,7 +1507,6 @@ "count": 11 } }, - { "id": "0f271100-8134-4cda-a88f-fd92f9c710f6", "name": "Get 1 new unique from elite clues",