Create Virtual Network with wrong Address Range should fail fast

[paczerny]

/!\ To report a security issue please follow this procedure:
[https://github.com/OpenNebula/one/wiki/Vulnerability-Management-Process]

Description
When creating a Virtual Network with wrong Address Range, the network is created. Internally the oned calls vnet_create action and after that ARs are parsed - if some AR is wrongly defined the network switches to error state. Because the failure is not during the onevnet create command the user may miss it.

To Reproduce
Create a template file vnet.tmpl:

         NAME   = "fail_ar"
         BRIDGE = br0
         VN_MAD = dummy
         AR = [ TYPE="IP4", SIZE="250" ]

Call onevnet create vnet.tmpl - commands succeeds, the network ends in error state.

Expected behavior
The command onevnet create vnet.tmpl should fail with descriptive error message.

Details

• Affected Component: oned
• Hypervisor: -
• Version: master, 7.4

Additional context
Bug introduced in 6.4 release, which adds vnet_create action

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)