Skip to content

Remove double error report code #47

Description

@coleherman43

Currently validation errors are logged as large fstrings directly, and right next to each one we write the same fstring to a parameter of the ValidationError object (error_message). We can just save it once as

error_message = f"Message here"

and then do logging and reporting more simply as

logger.error(error_message)
validation_errors.append(ValidationError(idx+2, ... [other values] ..., error_message))

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions