docs: describe what APP_CACHE_BUSTER actually does - #13
Open
anurag6569201 wants to merge 1 commit into
Open
anurag6569201 wants to merge 1 commit into
anurag6569201 wants to merge 1 commit into
Conversation
Source PR: appwrite#13475 Source head: c05099f
✅ Shipwright · ApproveRecommendation: approve PR #13 · Tier
Findings✅ No actionable findings detected. Cost: $0.0000 · 0 tokens · 0s · 0 fix iteration(s) Open the Shipwright check for full evidence and the audit bundle. Use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The release checklist said to
increment APP_CACHE_BUSTER by 1on every patch, and listed it alongsideAPP_VERSION_STABLEas metadata that must match the target version. It is not a version number and does not track releases.Its only consumer is the md5 in
Request::cacheIdentifier(), which keys the server-side response cache for the seven routes labelledcache— file preview and the avatars endpoints. Changing it changes every key at once, so every entry is orphaned and every image transform and screenshot regenerates. That is worth doing only when the cached bytes would now be wrong.Practice already disagreed with the docs:
1.9.6→2.0.0deliberately kept4327in 98f425f, because 2.0 changes no cached response shape. This makes the docs match.Docs only, no behaviour change.
Source merge-base:
7da1cdb08916a4b6a86e5e23ad52c3a5f0668a2bSource head:
c05099ff03ebc7bb6e4858905a4ab72dc24b0bcd