Skip to content

test: refresh live-query stats explicitly - #10

Open
anurag6569201 wants to merge 1 commit into
qa/agent-sveltejs-kit/pr-10-16946/basefrom
qa/agent-sveltejs-kit/pr-10-16946/head
Open

anurag6569201 wants to merge 1 commit into
qa/agent-sveltejs-kit/pr-10-16946/basefrom
qa/agent-sveltejs-kit/pr-10-16946/head

Conversation

@anurag6569201

Copy link
Copy Markdown

Fixes a pre-existing async live-query test flake observed on sveltejs#16944 in CI run https://github.com/sveltejs/kit/actions/runs/32994679500.

The stats button previously awaited get_stats() without first refreshing its cached query. Cache eviction therefore depended on FinalizationRegistry/GC timing, and CI polling could repeatedly read the original cleanup_count after reconnecting.

Explicitly start a refresh, then await get_stats() again. Query proxies for the same query share the cached resource, so the second proxy resolves with fresh server state while using the idiomatic remote-query API.

The follow-up passed async-app type checking, formatting, and diff validation. A targeted Playwright build also completed, though browser launch was unavailable in the sandbox because required Chromium system libraries could not be installed.

Source merge-base: 2e4bdb3df6a21a7c5a441a9b10a1799297ba1a5d
Source head: 9f430cd1ee0f9e52d39f64b2828f98c0ab5c3f86

@shipwright-agent

Copy link
Copy Markdown

✅ Shipwright · Approve

Recommendation: approve PR #10 · Tier T1
Checks: 0 total · 0 needing attention

Next step: ready to merge.

Findings (3)

  • HIGH refresh_stats() now calls get_stats() twice: once for refresh() and once for the awaited result. · page.svelte:20
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • LOW The intent of calling get_stats().refresh() before awaiting get_stats() is unclear without reading the implementation. · page.svelte:20
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • LOW No security-relevant change is introduced, but the double call to get_stats() increases the attack surface for any side effects or resource consumption in that function. · page.svelte:20
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.

Fireworks usage: 5,115 input · 322 output · 5,437 total tokens · $0.0013 · 7s · 0 fix iteration(s)

Open the Shipwright check for full evidence and the audit bundle. Use /shipwright rerun to verify again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant