test: refresh live-query stats explicitly - #10
Open
anurag6569201 wants to merge 1 commit into
Open
anurag6569201 wants to merge 1 commit into
anurag6569201 wants to merge 1 commit into
Conversation
Source PR: sveltejs#16946 Source head: 9f430cd
✅ Shipwright · ApproveRecommendation: approve PR #10 · Tier
Findings (3)
Fireworks usage: 5,115 input · 322 output · 5,437 total tokens · $0.0013 · 7s · 0 fix iteration(s) Open the Shipwright check for full evidence and the audit bundle. Use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a pre-existing async live-query test flake observed on sveltejs#16944 in CI run https://github.com/sveltejs/kit/actions/runs/32994679500.
The stats button previously awaited
get_stats()without first refreshing its cached query. Cache eviction therefore depended onFinalizationRegistry/GC timing, and CI polling could repeatedly read the originalcleanup_countafter reconnecting.Explicitly start a refresh, then await
get_stats()again. Query proxies for the same query share the cached resource, so the second proxy resolves with fresh server state while using the idiomatic remote-query API.The follow-up passed async-app type checking, formatting, and diff validation. A targeted Playwright build also completed, though browser launch was unavailable in the sandbox because required Chromium system libraries could not be installed.
Source merge-base:
2e4bdb3df6a21a7c5a441a9b10a1799297ba1a5dSource head:
9f430cd1ee0f9e52d39f64b2828f98c0ab5c3f86