Problem
I think that the option names for Redis host and port should be renamed to be more Redis specific. When looking at the configuration in your SocketCluster project, it is unclear what the host and port properties are used for.
Proposal
Old:
const socketCluster = new SocketCluster({
brokerOptions: {
host: '54.204.147.15',
port: 6379
}
});
New:
const socketCluster = new SocketCluster({
brokerOptions: {
redis: {
host: '54.204.147.15',
port: 6379
// Also supports easily passing additional options in the future
}
}
});
@jondubois I would be happy to work on this change if we decide this is the right direction.
Problem
I think that the option names for Redis host and port should be renamed to be more Redis specific. When looking at the configuration in your SocketCluster project, it is unclear what the
hostandportproperties are used for.Proposal
Old:
New:
@jondubois I would be happy to work on this change if we decide this is the right direction.