Under high load, proof response correlation id's do not remain unique.

[DibbsZA]

Scenario:

1: Agent is instructed, via many parallel requests, each to generate Proof Requests for a different client wallet.
2: The Agent starts generating AuthorizationRequestURI's (apparently in several threads)
3: It appears that the variable authorizationRequestOpts is updated by each of these threads leaving the same/last value set for many of the requests.

Result: Not all wallets actually receive the request or can process response correctly.

We have found that a small change in this line seems to resolve the issue but perhaps the problem runs deeper.

https://github.com/Sphereon-Opensource/SIOP-OID4VP/blob/b7ab7418ded18ce3219813f935f94192b31fd1e9/src/rp/RP.ts#L111

[nklomp]

Thanks, we will start on a refactor soon, and the way we are handling/mixing options at class level and as arguments will be revised as part of that, as it brings too much optionality and also potential for bugs. Probably the issue indeed runs deeper.