Performance concerns

[Mikan1520]

Got this working in 5.8, but as long as I have the swui component, I'm seeing an increase of 4ms per frame, even without loading an html file. Is this just a limitation of cef in unreal, or would it be caused by something in the plugin?

[Mikan1520]

Did some profiling, seems to be slate times that go up specifically. Left is with swui component, right is without (backwards I know, my bad)

Click to show image

[ZenaMel]

Hey @Mikan1520, great you got it up and running.

As for the performance concern, I did do some profiling and made the base rendering loop for SWUI as good as I personally could and tested by "feel" and with a full HUD it seemed "good enough" to me, in other words, negligible impact on framerate and no CPU hitching.

As far as profiling goes I think what's worth looking it would be the performance on a packaged build rather than the in-editor profiling but that's just my guess.

[ZenaMel]

Did some profiling, seems to be slate times that go up specifically. Left is with swui component, right is without (backwards I know, my bad)

Click to show image

@Mikan1520 if you're open to it I'd love to have your PR with the changes needed to be compatible with 5.8 if that's not much trouble by the way

[Mikan1520]

Hey @Mikan1520, great you got it up and running.

As for the performance concern, I did do some profiling and made the base rendering loop for SWUI as good as I personally could and tested by "feel" and with a full HUD it seemed "good enough" to me, in other words, negligible impact on framerate and no CPU hitching.

As far as profiling goes I think what's worth looking it would be the performance on a packaged build rather than the in-editor profiling but that's just my guess.

Worth noting that I did try a packaged build, and saw the exact same performance loss. Editor made no difference in that regard other than having lower overall performance. I expect it's an issue with cef in 5.8 specifically, as even if I had nothing rendering (no file loaded), the performance loss came into effect. 4ms is a pretty big hit, to be fair.
The only way I saw of not getting that performance loss is skipping the call to InitRenderer, even commenting out the various loops within SWUI made no change, so I wonder if something has changed with regards to cef in 5.8
Opened a PR as well, for the changes I had to make