PrivateCoin deserializarion

[CryptoManiac]

PrivateCoin object deserializarion doesn't work.

Just one example:

        libzerocoin::PrivateCoin newCoin(params);

        CDataStream serializedPrivCoin(SER_NETWORK, PROTOCOL_VERSION);
        serializedPrivCoin << newCoin;

        libzerocoin::PrivateCoin newPrivCoin(params, serializedPrivCoin); // Compilation fails here

Compilation fails with the following output

In file included from ../Zerocoin.h:52:0,
                 from ../Test.cpp:20:
../Coin.h: In constructor 'libzerocoin::PrivateCoin::PrivateCoin(const libzerocoin::Params*, Stream&) [with Stream = CDataStream]':
../Test.cpp:92:66:   instantiated from here
../Coin.h:88:54: error: no matching function for call to 'libzerocoin::PublicCoin::PublicCoin()'
../Coin.h:88:54: note: candidates are:
../Coin.h:50:2: note: libzerocoin::PublicCoin::PublicCoin(const libzerocoin::Params*, const Bignum&, libzerocoin::CoinDenomination)
../Coin.h:50:2: note:   candidate expects 3 arguments, 0 provided
../Coin.h:42:2: note: libzerocoin::PublicCoin::PublicCoin(const libzerocoin::Params*)
../Coin.h:42:2: note:   candidate expects 1 argument, 0 provided
../Coin.h:38:2: note: template<class Stream> libzerocoin::PublicCoin::PublicCoin(const libzerocoin::Params*, Stream&)
../Coin.h:35:7: note: libzerocoin::PublicCoin::PublicCoin(const libzerocoin::PublicCoin&)
../Coin.h:35:7: note:   candidate expects 1 argument, 0 provided
make: *** [Test.o] Error 1
$ 

It seems that something wrong with newPrivCoin->publicCoin property initializarion. I guess that empty constructor should be added into the PublicCoin class implementation.

[ABISprotocol]

Has this been resolved or is it still a thing?

[imichaelmiers]

@CryptoManiac
Hi, apologies for the delay. I took a quick look at this when it came in and couldn't reproduce it. I wanted to look into it more later since I hate when people reply to my bugs with "no repro, closed". Coming back to it briefly now, I still can't reproduce the compilation issue.

This code you gave me compiles and runs in the dev branch on my computer if I stick the bellow code in Test.cpp and add the hooks for calling it. It doens't test that serialization works correctly at the moment, but it does compile and run with OSX 10.6 and g++ 4.2.

bool 
Test_privateCoinSerialization(){
    libzerocoin::PrivateCoin newCoin(g_Params);

    CDataStream serializedPrivCoin(SER_NETWORK, PROTOCOL_VERSION);
    serializedPrivCoin << newCoin;

    libzerocoin::PrivateCoin newPrivCoin(g_Params, serializedPrivCoin); // Compilation works here
}

Of course, I'm not releasing my computer along with the library, so that's of little consolation.

Can you provide any more details or repro steps? Were you on the dev branch or master? What version of GCC, operating system, etc ? Can you check that the code still is broken in the dev branch for you?

thanks

[ABISprotocol]

@imichaelmiers Thanks for addressing this, I look forward to seeing the results of your labor and thoughts from @CryptoManiac.

[CryptoManiac]

@imichaelmiers, I'm using Ubuntu 12.04 as the build environment. All development packages are installed from repository, no custom builds used.

P.S. sorry for the late answer, I was too busy to be productive here :( I'll try the dev branch ASAP.