Skip to content

Should aggregation be the sum over absolute contributions? #23

Description

@chathika

In line 6 of aggregated_contribution the individual contributions are summed.

Shouldn't the contributions be converted to their absolute values first and then summed?

For example, a joint feature, that has both high negative and low negative contributions would get a low aggregated joint contribution as of the current implementation?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions