From 41be87466aab7520827c58fd798d3cd1042995fc Mon Sep 17 00:00:00 2001 From: Xianyuan Jia Date: Tue, 28 Apr 2026 14:38:23 -0700 Subject: [PATCH 1/2] Add instruction to skip "Before you begin" steps to install gcloud CLI --- README.md | 3 ++- src/results_uploader/gcloud_setup.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index ed4b94c..07b3295 100644 --- a/README.md +++ b/README.md @@ -67,7 +67,8 @@ Google Cloud Storage bucket: 1. Confirm/request access to the shared GCP project with your Google contact. The Googler will give you a project name to use. -2. Install the gcloud CLI from https://cloud.google.com/sdk/docs/install +2. Install the gcloud CLI from https://docs.cloud.google.com/sdk/docs/install-sdk#latest-version + * Skip the "Before you begin" steps. * If installation fails with the above method, try the alternative linked [here](https://cloud.google.com/sdk/docs/downloads-versioned-archives#installation_instructions). 3. Download and execute [this script](src/results_uploader/gcloud_setup.py) to diff --git a/src/results_uploader/gcloud_setup.py b/src/results_uploader/gcloud_setup.py index 912819c..b4769fa 100755 --- a/src/results_uploader/gcloud_setup.py +++ b/src/results_uploader/gcloud_setup.py @@ -31,7 +31,8 @@ def _run_gcloud_command(args: list[str]) -> None: except FileNotFoundError: logging.error( 'Failed to run `gcloud` commands! Please install the `gcloud` CLI ' - 'from https://cloud.google.com/sdk/docs/install\n') + 'from https://docs.cloud.google.com/sdk/docs/install-sdk#latest-version. ' + '(Skip the "Before you begin" steps.) \n') raise From de39fb8ad3ce7c0f7b3d073db9d3cdea40a24791 Mon Sep 17 00:00:00 2001 From: Kolin Lu Date: Tue, 28 Apr 2026 16:41:55 -0700 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- src/results_uploader/gcloud_setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/results_uploader/gcloud_setup.py b/src/results_uploader/gcloud_setup.py index b4769fa..6f2da8d 100755 --- a/src/results_uploader/gcloud_setup.py +++ b/src/results_uploader/gcloud_setup.py @@ -31,8 +31,8 @@ def _run_gcloud_command(args: list[str]) -> None: except FileNotFoundError: logging.error( 'Failed to run `gcloud` commands! Please install the `gcloud` CLI ' - 'from https://docs.cloud.google.com/sdk/docs/install-sdk#latest-version. ' - '(Skip the "Before you begin" steps.) \n') + 'from https://docs.cloud.google.com/sdk/docs/install-sdk#latest-version ' + '(Skip the "Before you begin" steps.)') raise