Skip to content

AuthUserEnvVar and AuthPassEnvVar are used in different contexts #18

Description

@dayflower

AuthUserEnvVar and AuthPassEnvVar were originally introduced for delegating auth user and password to ssh process environment. (#6, 5f54a8f)

e.g.

$ git-http-backend -auth_user_env_var=AUTH_USERNAME -auth_pass_env_var=AUTH_PASSWORD

and when a user accesses with user:foo, password:bar, then

AUTH_USERNAME=foo AUTH_PASSWORD=bar git ...

However, #17 introduced Basic Auth mechanism and utilize AuthUserEnvVar and AuthPassEnvVar for accepting user name and password.

If an operator starts with:

$ git-http-backend -auth_user_env_var=foo -auth_pass_env_var=bar -require_auth

then, only the user whose name is 'foo' and whose password is 'bar' is accepted, that's fine.

But this setting also enables "delegating auth info" feature above, then from the perspective of the git process, following environments are passed.

foo=foo bar=bar git ...

It's quite meaningless.

How about making different parameter for these two contexts?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions