From 28d976c2555cb3dd133e14c57236f413539a479f Mon Sep 17 00:00:00 2001 From: Tushar Suresh Date: Wed, 15 Jul 2015 17:43:30 +0000 Subject: [PATCH 1/2] Fail fast on unimplemented methods --- amazon_kclpy/kcl.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/amazon_kclpy/kcl.py b/amazon_kclpy/kcl.py index e77a2fe2..14d6331a 100644 --- a/amazon_kclpy/kcl.py +++ b/amazon_kclpy/kcl.py @@ -175,7 +175,7 @@ def initialize(self, shard_id): :type shard_id: str :param shard_id: The shard id that this processor is going to be working on. ''' - return + raise NotImplementedError @abc.abstractmethod def process_records(self, records, checkpointer): @@ -192,7 +192,7 @@ def process_records(self, records, checkpointer): :type checkpointer: amazon_kclpy.kcl.Checkpointer :param checkpointer: A checkpointer which accepts a sequence number or no parameters. ''' - return + raise NotImplementedError @abc.abstractmethod def shutdown(self, checkpointer, reason): @@ -210,7 +210,7 @@ def shutdown(self, checkpointer, reason): shard so that this processor will be shutdown and new processor(s) will be created to for the child(ren) of this shard. ''' - return + raise NotImplementedError class MalformedAction(Exception): ''' From ee1a059d8b4ec78ae85f10040f88af594cd0fee6 Mon Sep 17 00:00:00 2001 From: Tushar Suresh Date: Wed, 15 Jul 2015 17:45:18 +0000 Subject: [PATCH 2/2] Remove empty file --- amazon_kclpy/jars/__init__.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 amazon_kclpy/jars/__init__.py diff --git a/amazon_kclpy/jars/__init__.py b/amazon_kclpy/jars/__init__.py deleted file mode 100644 index e69de29b..00000000