Skip to content

Consider hardcoded format requires for client-side support #3

Description

@aklos

First of all, thanks for this nice library. It works great server-side, but it doesn't support client-side because of the use of fs.

Is there any reason why it can't require the VRM formats like below?

const formats = [
	require('./diplomatic.js'),
	require('./gb-1903.js'),
	require('./gb-1932.js'),
	require('./gb-1963.js'),
	require('./gb-1983.js'),
	require('./gb-2001.js'),
	require('./military.js'),
	require('./ni-1903.js'),
	require('./ni-1966.js')
];

Discovering the formats dynamically is better, but the list of formats seems pretty static.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions