Collection attributes not statically scheduled correctly (aps2scala)

[boyland]

Using aps2scala collection attributes (as opposed to collection globals) are not scheduled correctly:

with "tiny";

module TINY_COLL[T :: var TINY[]] extends T
begin
  type Integers := SET[Integer];

  collection attribute Wood.sum : Integer :> 0, (+);

  pragma synthesized(sum);

  match ?l=leaf(?x) begin
    l.sum :> x;
  end;
  match ?b=branch(?x,?y) begin
    b.sum :> x.sum;
    b.sum :> y.sum;
  end;

  match ?p=root(?b) begin
  end;

end;

Not only is only one of the collection assignments activated (as can be seen below), but the generated code uses "set/assign" rather than something that collects multiple values.

Furthermore, even collection globals are not statically scheduled correctly if there are multiple collection assignments (e.g. from test-coll.aps):

   match ?l=leaf(?x) begin
     sum :> x;
     leaves :> {x};
+    sum :> 10; 
   end;

NB: dynamic scheduling works correctly in both cases.

[boyland]

The problem is evident in the C++ implementation too.

[amir734jj]

Just trying to add more description to the issue:
Running: ../bin/aps2scala -S -p .:../base tiny-impl

tiny-impl.aps

with "tiny";
module TINY_IMPL[T :: var TINY[]] extends T
begin
  type Integers := SET[Integer];

  type Leaves := SET[Wood];
  collection attribute Wood.sum : Integer :> 0, (+);

  var collection leaves : Leaves := { };
  pragma synthesized(sum);

  match ?l=leaf(?x) begin
     l.sum :> 2;
     leaves :> {l};
     l.sum :> 10; 
  end;

  match ?b=branch(?x,?y) begin
    b.sum :> x.sum;
    b.sum :> y.sum;
  end;

  match ?p=root(?b) begin
  end;
end;

Results in:

  def visit_1_1_1(anchor : T_Wood) : Unit = anchor match {
    case p_leaf(v_l,v_x) => {
      // l.G[Wood]'shared_info is ready now.
      a_leaves.set(t_Leaves.v_single(v_l));
      // a_sum.set(v_l,2);  <---------------------- missing
      a_sum.set(v_l,10);
    }
  }

  def visit_1_1_0(anchor : T_Wood) : Unit = anchor match {
    case p_branch(v_b,v_x,v_y) => {
      // b.G[Wood]'shared_info is ready now.
      // shared info for x is ready.
      visit_1_1(v_x);
      // x.G[Wood]'shared_info$Xleaves is ready now.
      // x.sum is ready now.
      // shared info for y is ready.
      visit_1_1(v_y);
      // y.G[Wood]'shared_info$Xleaves is ready now.
      // b.G[Wood]'shared_info$Xleaves
      // y.sum is ready now.
      // a_sum.set(v_b,a_sum.get(v_x));   <---------------------- missing
      a_sum.set(v_b,a_sum.get(v_y));
    }
  }

[boyland]

It seems that even normal attribute share a similar problem: e.g. if

   x := 3;
   if ... then
     x := 4;
   endif;

Here since the assignment to 3 is first, it should take precedence. But it doesn't.

[amir734jj]

This issue is fixed in the new SCC static code generation:

  def visit_1_1_0(anchor : T_Wood) : Unit = anchor match {
    case p_branch(v_b,v_x,v_y) => {

      visit_1_1(v_x);

      visit_1_1(v_y);
      a_sum.set(v_b,a_sum.get(v_x));
      a_sum.set(v_b,a_sum.get(v_y));
    }
  }

Also the test-coll.aps is also fixed:

  def visit_1_1_1(anchor : T_Wood) : Unit = anchor match {
    case p_leaf(v_l,v_x) => {
      a_sum.set(v_x);
      a_sum.set(10);
      a_leaves.set(t_Integers.v_single(v_x));
    }
  }

We can close this issue.