Skip to content

Should we use -fsanitize on builds running tests? #183

Description

@vfazio

In light of the recent patch series, I wonder if there's value in using -fsanitize=address,leak,undefined when performing builds with tests.

I apparently did a build when testing some free-threaded things: #117 (comment)

How I did that escapes me at the moment, but I assume we can figure it out again if we think these may add value.

The caveat for python is that we may need to find a way to inject the flags into the build via setuptools (build_tests.py). I think it uses the flags from the python build itself and we don't pass in anything like CFLAGS_EXTRA or what have you so it's blissfully unaware about these directives.

If we get the builds working, it may be interesting to test on a branch without the recent patches to see if the issues that were identified get flagged.

@brgl thoughts?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions