You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You carry a lot of the review load on this repo, so I wanted to introduce myself properly and offer some help.
I have been reviewing arc-node PRs and issues from the community side — #299, #306, #307, #308 and #309, plus the CI OOM report in #298 and the memory fix in #310 that you approved earlier today. What I try to bring is verification rather than opinion: checking upstream commit containment against the reth pin rather than trusting a linked PR, testing merge order between open PRs before claiming a conflict, and confirming behaviour against live RPC or on-chain state before asserting it.
If a second pair of eyes would ever be useful on a PR, an issue, or a repo-wide change, please feel free to tag @osr21. I am glad to help, and I will always show the verification behind anything I claim so it is easy to check rather than take on trust.
One immediately concrete example, if it is useful: #238 and #226 both merged within the last hour, and #306 is still open against overlapping files (docs/installation.md and the docker-compose image comments). I checked #306 against both of those while they were still open and reported the merge behaviour at the time. I am happy to re-run that check against current main and report what, if anything, #306 now needs — just say the word.
I am conscious that unsolicited review can add noise rather than remove it, so I will take my cue from you: tag me when it helps, and otherwise I will keep to the normal etiquette — nothing on drafts, inline review threads rather than long top-level comments, and scoped strictly to what I have actually verified.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Hi @ZhiyuCircle,
You carry a lot of the review load on this repo, so I wanted to introduce myself properly and offer some help.
I have been reviewing arc-node PRs and issues from the community side — #299, #306, #307, #308 and #309, plus the CI OOM report in #298 and the memory fix in #310 that you approved earlier today. What I try to bring is verification rather than opinion: checking upstream commit containment against the reth pin rather than trusting a linked PR, testing merge order between open PRs before claiming a conflict, and confirming behaviour against live RPC or on-chain state before asserting it.
If a second pair of eyes would ever be useful on a PR, an issue, or a repo-wide change, please feel free to tag @osr21. I am glad to help, and I will always show the verification behind anything I claim so it is easy to check rather than take on trust.
One immediately concrete example, if it is useful: #238 and #226 both merged within the last hour, and #306 is still open against overlapping files (docs/installation.md and the docker-compose image comments). I checked #306 against both of those while they were still open and reported the merge behaviour at the time. I am happy to re-run that check against current main and report what, if anything, #306 now needs — just say the word.
I am conscious that unsolicited review can add noise rather than remove it, so I will take my cue from you: tag me when it helps, and otherwise I will keep to the normal etiquette — nothing on drafts, inline review threads rather than long top-level comments, and scoped strictly to what I have actually verified.
Thanks for the work you put into the repo.
Best,
osr21
All reactions