run-upgrade-test.sh references missing nightly-upgrade.yml workflow

[Kewe63]

Summary

scripts/run-upgrade-test.sh attempts to trigger a GitHub Actions workflow named nightly-upgrade.yml, but that workflow file does not exist in .github/workflows.

As a result, following the script's remote execution path will generate a gh workflow run command that points to a missing workflow.

---

Affected File

scripts/run-upgrade-test.sh

---

Observed Behavior

The script builds a GitHub CLI command targeting:

nightly-upgrade.yml

For example, with --dry-run:

bash scripts/run-upgrade-test.sh --remote origin --dry-run --from 0.7.3-dev --to 0.8.0-dev

Observed output:

gh workflow run nightly-upgrade.yml -R circlefin/arc-node --ref main -f from_version=0.7.3-dev -f to_version=0.8.0-dev

But the workflow file is not present under:

.github/workflows/nightly-upgrade.yml

A direct file check returns not found:

test -f .github/workflows/nightly-upgrade.yml; echo $?

Observed result:

1

---

Expected Behavior

The script should reference an existing workflow, or the repository should include the workflow file that the script expects.

For example, one of the following should be true:

• .github/workflows/nightly-upgrade.yml exists, or
• scripts/run-upgrade-test.sh references the correct existing workflow name.

---

Why This Matters

The script appears to provide the documented/maintained path for running upgrade tests remotely. If it references a workflow that no longer exists or was renamed, users and maintainers cannot use it successfully.

The dry-run mode also gives a command that looks valid but cannot be executed successfully because the workflow target is missing.

---

Suggested Fix

Either:

1. update scripts/run-upgrade-test.sh to reference the current workflow file, if this workflow was renamed, or
2. restore/add .github/workflows/nightly-upgrade.yml if the script is still supposed to trigger that workflow.

---

Potential Regression Test

A lightweight shell test could verify that the workflow referenced by scripts/run-upgrade-test.sh exists under .github/workflows.

At minimum, CI or a script check could assert:

test -f .github/workflows/nightly-upgrade.yml

or, better, parse the workflow name from scripts/run-upgrade-test.sh and verify that the referenced workflow file exists.

---

Duplicate Check

I checked the existing public issue/PR index for this repository and did not find a direct duplicate for this missing nightly-upgrade.yml workflow reference.

Related but not duplicate:

Issue #252 appears to involve example version documentation for the same script, but this issue is specifically about the script referencing a workflow file that is not present.