From a5917d04028a98ec9e18fd85dbe9ad2dfd5239fd Mon Sep 17 00:00:00 2001 From: Kewe63 <86300262+Kewe63@users.noreply.github.com> Date: Thu, 3 Sep 2026 11:05:33 +0300 Subject: [PATCH] fix: reject zero genesis block gas limit --- scripts/genesis/ProtocolConfig.ts | 2 +- tests/unit/protocol-config-genesis.test.ts | 79 ++++++++++++++++++++++ 2 files changed, 80 insertions(+), 1 deletion(-) create mode 100644 tests/unit/protocol-config-genesis.test.ts diff --git a/scripts/genesis/ProtocolConfig.ts b/scripts/genesis/ProtocolConfig.ts index 6b52ce6b..7cf7933b 100644 --- a/scripts/genesis/ProtocolConfig.ts +++ b/scripts/genesis/ProtocolConfig.ts @@ -71,7 +71,7 @@ export const schemaProtocolConfig = z inverseElasticityMultiplier: schemaBigInt.min(0n).max(10000n), minBaseFee: schemaBigInt.min(0n).max(maxUint64), maxBaseFee: schemaBigInt.min(0n).max(maxUint64), - blockGasLimit: schemaBigInt.min(0n).max(maxUint64), + blockGasLimit: schemaBigInt.min(1n).max(maxUint64), }), consensusParams: z .object({ diff --git a/tests/unit/protocol-config-genesis.test.ts b/tests/unit/protocol-config-genesis.test.ts new file mode 100644 index 00000000..5e05114a --- /dev/null +++ b/tests/unit/protocol-config-genesis.test.ts @@ -0,0 +1,79 @@ +// Copyright 2026 Circle Internet Group, Inc. All rights reserved. +// +// SPDX-License-Identifier: Apache-2.0 +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +import { expect } from 'chai' +import { schemaProtocolConfig } from '../../scripts/genesis/ProtocolConfig' + +const proxyAdmin = '0x0000000000000000000000000000000000000001' +const owner = '0x0000000000000000000000000000000000000002' +const controller = '0x0000000000000000000000000000000000000003' +const pauser = '0x0000000000000000000000000000000000000004' +const maxUint64 = 18446744073709551615n + +const protocolConfig = { + proxy: { + admin: proxyAdmin, + }, + owner, + controller, + pauser, + feeParams: { + alpha: 1n, + kRate: 1n, + inverseElasticityMultiplier: 1n, + minBaseFee: 0n, + maxBaseFee: 1_000_000n, + blockGasLimit: 30_000_000n, + }, +} + +describe('ProtocolConfig genesis schema', () => { + it('accepts a positive block gas limit', () => { + expect(() => + schemaProtocolConfig.parse({ + ...protocolConfig, + feeParams: { + ...protocolConfig.feeParams, + blockGasLimit: 1n, + }, + }), + ).to.not.throw() + }) + + it('rejects a zero block gas limit', () => { + expect(() => + schemaProtocolConfig.parse({ + ...protocolConfig, + feeParams: { + ...protocolConfig.feeParams, + blockGasLimit: 0n, + }, + }), + ).to.throw() + }) + + it('rejects block gas limits above uint64', () => { + expect(() => + schemaProtocolConfig.parse({ + ...protocolConfig, + feeParams: { + ...protocolConfig.feeParams, + blockGasLimit: maxUint64 + 1n, + }, + }), + ).to.throw() + }) +})