Skip to content
This repository was archived by the owner on Oct 13, 2021. It is now read-only.
This repository was archived by the owner on Oct 13, 2021. It is now read-only.

reload思路清晰,根据理解发现了几处问题 #15

Description

@zhyingkun
  1. 实现中有数个 error 调用参数写错(145 行、162 行、176 行)
  2. 对于其他 thread 从 level 为 2 的栈帧开始更新会导致 level 为 0 和 1 的栈帧没有更新到(668 行)
  3. solve_global 的时候没有考虑到模块名可能包含"."的情况(524 行)
  4. solve_global 函数中第 527 行和第 532 行的 break 会导致直接中断对 global_dummy 的遍历,从逻辑上来说应该是改成 goto
  5. reload 一个模块,其依赖的模块也会被 reload,导致所有依赖的模块都必须遵循 reload 的限制(123 行设置的 require 函数)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions