Summary
Remove leftover FasterCSV-era naming now that the gem depends on Ruby's stdlib csv gem exclusively.
Problem
The codebase still carries names from the FasterCSV → CSV migration:
-
CSV_HANDLER constant in lib/comma.rb:
Used in lib/comma/generator.rb and the Rails renderer option slicing. The indirection no longer serves a purpose.
-
Spec descriptions in spec/comma/comma_spec.rb still say "FasterCSV options" (lines ~64, ~71) even though the implementation uses CSV.
This confuses new contributors who search for FasterCSV or wonder if a compatibility layer still exists.
Proposed approach
- Replace
CSV_HANDLER with CSV directly in:
lib/comma.rb
lib/comma/generator.rb
- Rename spec
describe / it strings from "FasterCSV" to "CSV" (behavior unchanged)
- Grep for any remaining
FasterCSV references in comments or docs
Files likely involved
lib/comma.rb
lib/comma/generator.rb
spec/comma/comma_spec.rb
README.md (if any stale references)
Acceptance criteria
Labels (suggested)
refactor, good first issue
Depends on
None. Can be done independently or bundled with #3/#4.
Summary
Remove leftover FasterCSV-era naming now that the gem depends on Ruby's stdlib
csvgem exclusively.Problem
The codebase still carries names from the FasterCSV → CSV migration:
CSV_HANDLERconstant inlib/comma.rb:Used in
lib/comma/generator.rband the Rails renderer option slicing. The indirection no longer serves a purpose.Spec descriptions in
spec/comma/comma_spec.rbstill say "FasterCSV options" (lines ~64, ~71) even though the implementation usesCSV.This confuses new contributors who search for FasterCSV or wonder if a compatibility layer still exists.
Proposed approach
CSV_HANDLERwithCSVdirectly in:lib/comma.rblib/comma/generator.rbdescribe/itstrings from "FasterCSV" to "CSV" (behavior unchanged)FasterCSVreferences in comments or docsFiles likely involved
lib/comma.rblib/comma/generator.rbspec/comma/comma_spec.rbREADME.md(if any stale references)Acceptance criteria
CSV_HANDLERconstant in the codebaseLabels (suggested)
refactor,good first issueDepends on
None. Can be done independently or bundled with #3/#4.