Skip to content

bug : attributeTag returns undefined if attribut has more then one reference #253

Description

@Ragnar-Oock

Some Data Elements with VR AT have a Value Multiplicity of 1-n, meaning they can have more than one value stored inside. However, the code and the comment on the function hint at an undefined return if the value length is strictly different then 4 bytes long.

code in question :

attributeTag (tag) {

examples of attribute of VR AT with a VM of 1-n :
(0028,0009) Frame Increment Pointer
(0028,000A) Frame Dimension Pointer

possible solutions :

  • change the signature of the function to accept an index parameter like the other parse function of this module and return the first value by default to keep retro compatibility
  • change the behavior of the function to return an array of values corresponding to all the attribute tags liste in the element (breaking changes)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions