Trust the d3mlabs tap in the docker build-deps installer - #137
Merged
Conversation
Current Homebrew refuses to load formulae from untrusted third-party taps
in non-interactive runs, so every image rebuild died installing dev from
the tap ("Refusing to load formula d3mlabs/d3mlabs/dev-core from
untrusted tap"), and :build deps from the same tap (wwise-cli) would hit
it next. Tap and trust d3mlabs/d3mlabs up front; || true keeps older
brews (no trust subcommand, no policy) working, and the installs below
still fail loudly if trust did not take. First seen: the snappy CI
runner's base-image rebuild after its lockfiles changed.
Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d3mlabs/d3mlabs/dev-corefrom untrusted tap"). The docker build-deps installer installs dev from that tap — and :build deps like snappy'swwise-clicome from it too — so every base-image rebuild on a current brew now fails.d3mlabs/d3mlabsup front, right after brew/ruby install.|| truekeeps older brews working (notrustsubcommand, no policy either); if a trust-enforcing brew somehow skipped it, the installs below still fail loudly.Note this script is fetched from
mainat image-build time, so merging this is what fixes consumers — no release needed.Test plan
Made with Cursor