Point the docker installer at dev-core's keg - #138
Merged
Conversation
The tap restructured dev into dev-core (the tool) plus dev (the org deployment: config + a dependency edge), but the docker build-deps installer still resolved DEV_HOME/GEM_HOME through `brew --prefix dev` - whose keg now carries only docs and etc config, so every image rebuild died with "No such file or directory -- .../opt/dev/libexec/dev/bin/ install-build-deps.rb". The image only runs install-build-deps.rb, which needs no org identity: install dev-core directly and resolve its keg. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devintodev-core(the tool) anddev(the org deployment: etc config + a dependency edge on dev-core), butdocker-install-build-deps.shstill resolvesDEV_HOME/GEM_HOMEthroughbrew --prefix dev— whose keg now carries only docs and org config. Every image rebuild dies withNo such file or directory -- .../opt/dev/libexec/dev/bin/install-build-deps.rb.install-build-deps.rb(reads the project'sdependencies.rb; needs no org identity), so installdev-coredirectly and resolve its keg.mainat image-build time, so merging is the fix.Test plan
Made with Cursor