Skip to content

Deploy tool can fail to unban masternodes if collateral address contains no fee UTXOs #304

Description

@strophy

Expected Behavior

Deploy tool should unban all banned masternodes without any issues

Current Behavior

The collateral address is also used as the fee source address when creating ProUpServTx in the mn-init role. In rare cases, the fee UTXO may have been spent and moved to a change address due to previous unban operations or operations on the testnet wallet on other clients.

Possible Solution

Deploy tool should check there is balance to pay for fees and create it if necessary before attempting to unban nodes. Alternatively, we could use a single fee source address, which would probably speed up mn-init because only one fee funding transaction would be necessary, rather than as many transactions as there are masternodes.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Version used:
  • Environment name and version (e.g. Chrome 39, node.js 5.4):
  • Operating System and version (desktop, server, or mobile):
  • Link to your project:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions