From 0bdf91344eca0223383ea15edd653c6a61cf64e4 Mon Sep 17 00:00:00 2001 From: Ali Basiri Date: Fri, 31 Jul 2026 22:41:01 -0700 Subject: [PATCH] ci: pin the Windows runner to windows-2022 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `windows-latest` label has rolled over to Windows Server 2025, whose image no longer ships the Visual Studio C++ toolchain node-gyp requires. Every Windows build now fails in electron-builder's install-app-deps while rebuilding node-pty: Error: Could not find any Visual Studio installation to use ⨯ node-gyp failed to rebuild '...\node_modules\node-pty' failedTask=installAppDeps Pinning to windows-2022 restores an image that still carries the toolchain. This went unnoticed because build.yml only runs on pull_request and v* tags — never on push to main — and fork PRs sit at action_required, so no run had actually executed in some time. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/build.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 95805d09..80804be6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -17,7 +17,13 @@ jobs: include: - os: macos-14 platform: mac - - os: windows-latest + # Pinned, not `windows-latest`: that label has rolled over to Windows + # Server 2025, whose image no longer ships the Visual Studio C++ + # toolchain node-gyp needs. On it, electron-builder's install-app-deps + # dies with "Could not find any Visual Studio installation to use" + # while rebuilding node-pty, so the Windows build never produces an + # artifact. 2022 still carries the toolchain. + - os: windows-2022 platform: win # Linux is split per-arch to avoid electron-builder bundling native # modules from the wrong architecture. When multiple targets (AppImage