Skip to content
This repository was archived by the owner on Mar 5, 2024. It is now read-only.
This repository was archived by the owner on Mar 5, 2024. It is now read-only.

Degree of freedom for variance calculation #31

Description

@coldfire79

I found that np.var function is used to calculate the variances in the code. Since the np.var function is using ddof=0 by default, we need to fix it to use ddof=1 to make all the equations aligned with the original paper.

I created a PR for it. Please take a look and let me know if you have any thoughts.

PR link: #30

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions