Skip to content

Enhance code re-usability#208

Description

@bahamut657

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

馃殌 Feature Proposal

It seems that it could not be possible to manage the upgrade event in custom way, without re-writing the entire logic.
The cause seems to be the Symbols used to store headers and socketRef into the rawReq object (kWs, kWsHead)

Motivation

Code re-usability.
In my case I have to add custom headers on HTTP Upgrade response #204 (ws library under the hood, supports it).

Example

Replace Symbol usage with simple string keys or expose some properties to manage the key name attribute.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions