Skip to content

Move generated code to subcrate #1

Description

@wcoenraads

The library consists of two parts: a set of types generated from the schema, and some functions that set up a websocket connection and handle things like reception statuses. It might be better to move the generated code to a second crate, and re-export the types in the main crate.

This was prompted by the fact that typify now generates error types (for e.g. conversion errors) in an error module, and it might be nice to place our own errors (S2ConnectionError) next to the generated errors. But that's difficult in the current architecture - combining generated and handwritten code nicely is tricky. Splitting the generated code off to its own crate should help with this, also for future cases where we want to present handwritten and generated code side-by-side.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions