Just: assorted follow-up fixes

- restate which `just` version these recipes actually need, correcting the earlier
  guess
- three recipes (Kotlin extractor generation and codegen) do what their name promised,
  which they had stopped doing since being folded into the shared verbs
- a coding-standards reference in `cpp/justfile` follows the fragment to where it now
  lives
- `format` reaches the rest of the checked Python, including the models-as-data
  scripts, which had no justfile of their own

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: redsun82

cpp/justfile

@@ -1,5 +1,5 @@
 import '../lib.just'
-import? '../../cpp-coding-standards.just'
+import? '../../buildutils-internal/just/cpp-coding-standards.just'
 
 [group('build')]
 build: (_build_dist "cpp")

java/ql/test-kotlin1/justfile

@@ -1,7 +1,8 @@
 import "../justfile"
 
-# These are CI shards of the Kotlin language tests, run as `just java
-# kotlin-language-tests-1`, so they only run when asked for by name.
+# These are CI shards of the Kotlin language tests, too long to run by accident,
+# so a verb coming from above passes over them and they run only when this
+# directory is named.
 explicit_verbs := ['test']
 
 # Kotlin tests may fail the diags.ql consistency test if the diagnostic limit is set.

java/ql/test-kotlin2/justfile

@@ -1,7 +1,8 @@
 import "../justfile"
 
-# These are CI shards of the Kotlin language tests, run as `just java
-# kotlin-language-tests-2`, so they only run when asked for by name.
+# These are CI shards of the Kotlin language tests, too long to run by accident,
+# so a verb coming from above passes over them and they run only when this
+# directory is named.
 explicit_verbs := ['test']
 
 # Kotlin tests may fail the diags.ql consistency test if the diagnostic limit is set.

misc/codegen/justfile

@@ -1,5 +1,5 @@
 import "../just/lib.just"
 
-test *ARGS="": (_bazel ['test', '@codeql//misc/codegen/...'])
+test *ARGS: (_bazel (['test', '@codeql//misc/codegen/...'] ++ ARGS))
 
 format *ARGS=".": (_format_py ARGS)

misc/just/README.md

@@ -4,10 +4,14 @@ have common verbs (`build`, `test`, `format`, `lint`, `generate`) that individua
 of the project can implement, and some common functionality that can be used to that
 effect.
 
-`just` 1.58 or newer is required: recipes forward argument lists using `set lists`, which
-is still unstable and did not exist before then. An older one stops with an
-`Unknown setting` error pointing at that line, which is clear enough but does not say
-which version to move to.
+`just` 1.53 or newer is required. Recipes forward argument lists rather than encoding
+them as whitespace separated strings, and every piece of that arrived in that one
+release: `set lists`, list literals, the `++` operator, and variadic parameters that pass
+their elements on one at a time rather than space-joined. Lists are still unstable, at
+1.58 as much as at 1.53, which is what `set unstable` in `defs.just` is for. An older
+`just` stops at the first list literal it parses, complaining about an unexpected `[` and
+saying nothing about versions; only `defs.just` read on its own gives the clearer
+`unknown setting` naming `lists`.
 
 # Forwarding
 

misc/scripts/models-as-data/justfile

@@ -0,0 +1,3 @@
+import "../../just/lib.just"
+
+format *ARGS=".": (_format_py ARGS)

python/justfile

@@ -6,7 +6,7 @@ build: (_build_dist "python")
 
 # Long filename needed for extractor tests (too long for Git on Windows)
 [no-cd]
-@_ensure_long_filename:
+@_ensure_long_filename: _require_semmle_code
     #!/usr/bin/env bash
     longfile="$SEMMLE_CODE/ql/python/ql/test/extractor-tests/long_path/really_rather_too_long_for_windows_path_length/with_unecessarily_longwinded_and_verbose_sub_folder/extremely_long_module_name_with_lots_of_digits_at_the_end_000000000000000000000000000000000000000000000000000000000000000000/test0000000000000000000000000000000000000000000000000000000.py"
     mkdir -p "$(dirname "$longfile")"